Solution (JavaScript) #1
Conversation
| {input: [4, 9, 9, 9], output: [5, 0, 0, 0]}, | ||
| {input: [9, 9, 9, 9], output: [0, 0, 0, 0]}, | ||
| ] | ||
| itParam("should increment array 'number'", cases, function({input, output}) { |
src/index.js
Outdated
| odometerReverse = function(array) { | ||
| let minusOne = true | ||
|
|
||
| for (let i = array.length; i--; i > -1) { |
There was a problem hiding this comment.
Interesting... this clearly works, but doesn't look like a normal for loop. Can you explain why it works as-is? How else might you write this?
There was a problem hiding this comment.
Oh, very interesting indeed... I believe what is happening is when the loop runs, the second statement, i--, is decrementing. Normally this would happen in the third statement but that always returning true. However the "should loop continue" statement is getting to 0 and terminating the loop. I believe this is demonstrated by this repl https://repl.it/@dustinyschild/CrushingStripedWorker
There was a problem hiding this comment.
This loop should be rewritten as follows:
for (let i = array.length - 1; i === 0; i--)
There was a problem hiding this comment.
Nope... But this is correct. Should have ran tests first!
for (let i = array.length - 1; i > -1; i--)
|
Could you provide more information as to how a user would be representing numbers with bases greater than 10? For example, would hexadecimal digits be represented as |
Let's assume you'll receive either all numbers or all strings. How would make sure the output is in the same format as the input? |
support for returning input type for output values
|
@dahlbyk I pushed a change that will allow for this function to return the same type that was provided, I ran into an edge case where the provided number could be all integers but the return value could not return all integers. I decided it would force all values to strings in this special case. Also this is the point I would start breaking this down into smaller functions. |
This is my solution to the odometer code challenge. It includes my implementation as well as parameterized tests that I used to write this code.
To run tests:
npm installnpm test